fix: keep `build` in `pixi upgrade` #2476

ruben-arts · 2024-11-13T15:55:16Z

This adds logic to make the pixi upgrade command a little more friendly.
It's an opinionated set of rules that we execute without any extra configuration options.

If you start with this manifest:

[dependencies]
python = "*"
python_abi = { version = "*", build = "5_cp313"}
pytest = { version = "*", build = "pyh*" }

pixi upgrade

Has this result:

[dependencies]
python = ">=3.13.0,<3.14"
python_abi = { version = ">=3.13,<3.14", build = "5_cp313" }
pytest = { version = ">=8.3.3,<8.4", build = "pyh*" }

Then running:

pixi upgrade python_abi

will give the following, because we assume you specifically want to upgrade it:

python = ">=3.13.0,<3.14"
python_abi = ">=3.13,<4"
pytest = { version = ">=8.3.3,<8.4", build = "pyh*" }

Running

pixi upgrade pytest

will give you the following, because you use a wildcard(*) we assume you want to keep it.

[dependencies]
python = ">=3.13.0,<3.14"
python_abi = ">=3.13,<4"
pytest = { version = ">=8.3.3,<8.4", build = "pyh*" }

…overwrite with empty fields

Hofer-Julian

Two small comments, apart from that it looks good to me

src/cli/upgrade.rs

docs/reference/cli.md

Co-authored-by: Hofer-Julian <[email protected]>

Hofer-Julian

Great job!

ruben-arts added 4 commits November 13, 2024 16:41

feat: loosen the logic around what is kept in an upgrade and what we …

c7d1583

…overwrite with empty fields

test: add tests for the extended upgrade logic

3b834a6

docs: clean

1230c16

fix: remove print and use match on StringMatcher

257b2d1

ruben-arts requested a review from Hofer-Julian November 14, 2024 15:43

Hofer-Julian requested changes Nov 14, 2024

View reviewed changes

src/cli/upgrade.rs Outdated Show resolved Hide resolved

docs/reference/cli.md Outdated Show resolved Hide resolved

ruben-arts and others added 2 commits November 15, 2024 13:38

Update docs/reference/cli.md

7db9518

Co-authored-by: Hofer-Julian <[email protected]>

Update src/cli/upgrade.rs

e36454a

Co-authored-by: Hofer-Julian <[email protected]>

Hofer-Julian approved these changes Nov 15, 2024

View reviewed changes

Hofer-Julian enabled auto-merge (squash) November 15, 2024 12:47

Hofer-Julian merged commit e96c6fe into prefix-dev:main Nov 15, 2024
43 checks passed

BrewTestBot mentioned this pull request Nov 18, 2024

pixi 0.37.0 Homebrew/homebrew-core#198081

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: keep `build` in `pixi upgrade` #2476

fix: keep `build` in `pixi upgrade` #2476

ruben-arts commented Nov 13, 2024 •

edited

Loading

Hofer-Julian left a comment

Hofer-Julian left a comment

fix: keep build in pixi upgrade #2476

fix: keep build in pixi upgrade #2476

Conversation

ruben-arts commented Nov 13, 2024 • edited Loading

Hofer-Julian left a comment

Choose a reason for hiding this comment

Hofer-Julian left a comment

Choose a reason for hiding this comment

fix: keep `build` in `pixi upgrade` #2476

fix: keep `build` in `pixi upgrade` #2476

ruben-arts commented Nov 13, 2024 •

edited

Loading